Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply github action to catch error in example pages #963

Merged
merged 1 commit into from
May 21, 2020
Merged

feat: apply github action to catch error in example pages #963

merged 1 commit into from
May 21, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Apr 29, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu changed the title feat: add option to doc config file feat: apply github action to catch error in example pages Apr 29, 2020
@seonim-ryu seonim-ryu requested a review from js87zz May 8, 2020 00:30
@seonim-ryu seonim-ryu force-pushed the feat/errorlog-github-action branch from dffd21c to bef7f02 Compare May 14, 2020 07:42
@seonim-ryu seonim-ryu force-pushed the feat/errorlog-github-action branch from bef7f02 to 427a9a3 Compare May 14, 2020 07:55
js87zz
js87zz approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seonim-ryu seonim-ryu merged commit 7f44dbd into master May 21, 2020
@seonim-ryu seonim-ryu deleted the feat/errorlog-github-action branch June 3, 2020 09:03
js87zz pushed a commit that referenced this pull request Jun 17, 2021
@seonim-ryu
chore: remove dist files
491bf0f 
#963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seonim-ryu @js87zz