feat: improve types, close #970

apps/editor/examples/example19-customizing-toolbar-buttons.html

@@ -88,8 +88,8 @@
       // Using Method: Customize the first button
       const toolbar = editor.getUI().getToolbar();
 
-      editor.eventManager.addEventType('clickCustomButton');
-      editor.eventManager.listen('clickCustomButton', function() {
+      editor.addEventType('clickCustomButton');
+      editor.on('clickCustomButton', function() {
         alert('Click!');
       });
 

apps/editor/index.d.ts

@@ -8,7 +8,7 @@ declare namespace toastui {
   type HandlerFunc = (...args: any[]) => void;
   type ReplacerFunc = (inputString: string) => string;
   type CodeMirrorType = CodeMirror.EditorFromTextArea;
-  type CommandManagerExecFunc = (name: string, ...args: any[]) => any;
+  type CommandManagerExecFunc = (editor: Editor | MarkdownEditor | WysiwygEditor, ...args: any[]) => any;
   type PopupTableUtils = LayerPopup;
   type AddImageBlobHook = (fileOrBlob: File | Blob, callback: Function, source: string) => void;
   type Plugin = (editor: Editor | Viewer, options: any) => void;
@@ -570,8 +570,19 @@ declare namespace toastui {
     public styleToSelectedCells(onStyle: SquireExt, options?: object): void;
   }
 
+  interface MarkdownRange {
+    from: CodeMirror.Position;
+    to: CodeMirror.Position;
+    ollapsed: boolean;
+  }
+
+  class CodeMirrorExt {
+    getCurrentRange(): MarkdownRange;
+    getEditor(): CodeMirrorType;
+  }
+
   // @TODO: change toastMark type definition to @toast-ui/toastmark type file through importing
-  class MarkdownEditor {
+  class MarkdownEditor extends CodeMirrorExt {
     static factory(
       el: HTMLElement,
       eventManager: EventManager,
@@ -695,7 +706,7 @@ declare namespace toastui {
   class EventManager {
     public addEventType(type: string): void;
 
-    public emit(eventName: string): any[];
+    public emit(eventName: string, ...args: any): any[];
 
     public emitReduce(eventName: string, sourceText: string): string;
 
@@ -729,6 +740,12 @@ declare namespace toastui {
 
     public addWidget(selection: Range, node: Node, style: string, offset?: number): void;
 
+    public addCommand(type: Command): void;
+
+    public addCommand(type: string, props: CommandPropsOptions): void;
+
+    public addEventType(type: string): void;
+
     public afterAddedCommand(): void;
 
     public blur(): void;
@@ -835,8 +852,6 @@ declare namespace toastui {
 
     public setMarkdown(markdown: string): void;
 
-    public setValue(markdown: string): void;
-
     public setCodeBlockLanguages(languages?: string[]): void;
   }
 }

apps/editor/src/js/editor.js

@@ -364,6 +364,14 @@ class ToastUIEditor {
     }
   }
 
+  /**
+   * Add event type when given event not exists
+   * @param {string} type Event type name
+   */
+  addEventType(type) {
+    this.eventManager.addEventType(type);
+  }
+
   /**
    * After added command.
    */