fix: pasting error in table when using custom sanitizer (fix #980) #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonim-ryu
commented
May 12, 2020
| * @param {boolean} needHtmlText pass true if need html text | ||
| * @returns {string|DocumentFragment} result | ||
| */ | ||
| function finalizeHtml(html, needHtmlText) { |
There was a problem hiding this comment.
해당 함수 로직은 새니타이저 모듈 외에 다른 곳에서도 범용적으로 사용될 수 있는 로직이라고 판단되어 domUtils 모듈로 이동함
seonim-ryu
force-pushed
the
fix/table-paste-with-custom-sanitizer
branch
from
14c9163 to
686efbb
Compare
js87zz
reviewed
May 13, 2020
js87zz
reviewed
May 13, 2020
js87zz
reviewed
May 13, 2020
js87zz
reviewed
May 13, 2020
| expect(pch.wwe.getSanitizer).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('sanitizes content of container', () => { |
There was a problem hiding this comment.
이 테스트가 있으니 첫번째 테스트는 없어져도 되지 않을까요? 검증하려는게 결국 디폴트 새니타이저를 탄 후 원하는 결과가 나오는가 라서 이 테스트로 첫번째 케이스까지 다 커버되는 것 같아요.
There was a problem hiding this comment.
커스텀 새니타이저도 스파이로 걸지말고 단순한 새니타이저 하나 만들어서 처리해도 될 것 같다는 생각이 드네요ㅎ 수정할게요~
js87zz
reviewed
May 13, 2020
| expect(tph.wwe.getSanitizer).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('returns html string as sanitized dom (DocumentFragment)', () => { |
There was a problem hiding this comment.
이 테스트에서도 역시 첫번째 케이스가 자동으로 커버되서 첫번째 케이스는 없어져도 되지 않을까요?
|
@seonim-ryu |
seonim-ryu
commented
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨