Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose adding command and event from editor (refs #970) #988

Closed
wants to merge 1 commit into from

Conversation

midgleyc
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Split out from #974: includes the addition of the addEventType function only.

I can change this to whichever method is decided, as discussed on #970, or it can be closed.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@midgleyc midgleyc mentioned this pull request May 15, 2020
6 tasks
@midgleyc midgleyc changed the title feat: Expose adding command and event from editor. feat: expose adding command and event from editor (refs #970) May 21, 2020
@midgleyc midgleyc force-pushed the editor-add-event-type branch from 8840f9b to db5e6dc Compare May 21, 2020 12:03
@stale
Copy link

stale bot commented Jun 20, 2020

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Jun 20, 2020
@stale
Copy link

stale bot commented Jun 27, 2020

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Jun 27, 2020
@seonim-ryu
Copy link
Member

@midgleyc This PR is the same as the comment below. I will fix it soon.

#987 (comment)

js87zz pushed a commit that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants