Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add silent option on setTime API for preventing firing change event #82

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Added silent option on setTime API for preventing firing 'change' event.
    • If it set true, the 'change' event will not be firing.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma self-assigned this Nov 21, 2022
@adhrinae adhrinae self-requested a review November 22, 2022 00:54
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항은 간단해서 코드 자체는 LGTM이지만, 테스트 구현도 간단할거라 생각하는데 메인 테스트 파일에 describe절 하나 더 만들어서 silent 인자 줬을 때 change 이벤트 호출 안되는지 확인하는 테스트 추가되었으면 좋겠습니다.

@@ -441,17 +441,18 @@ var TimePicker = defineClass(
/**
* Set values in spinboxes from time
* @private
* @param {boolean} silent flag for firing 'change' event

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param {boolean} silent flag for firing 'change' event
* @param {boolean} silent prevents firing 'change' event if it is true.

나머지도 이런 식으로 바꿔주셔요.

@jajugoguma jajugoguma requested a review from adhrinae November 22, 2022 06:19
@jajugoguma jajugoguma merged commit a5f6991 into master Nov 22, 2022
@jajugoguma jajugoguma deleted the feat/set-time-without-firing-event branch November 22, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants