Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update generated models #912

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: update generated models #912

merged 1 commit into from
Sep 9, 2024

Conversation

dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Sep 9, 2024

PR Type

Enhancement


Description

  • Updated generated GraphQL models in nhostclient/graphql/models_gen.go:
    • Removed several unused structs and enums
    • Added InferFunctionPermissions field to Hasura settings structs
  • Updated github.com/nhost/be dependency to latest version
  • Updated Go module checksums accordingly

Changes walkthrough 📝

Relevant files
Enhancement
models_gen.go
Update generated GraphQL models                                                   

nhostclient/graphql/models_gen.go

  • Removed BackupPresignedURL, ContainerError, LastError, Log, Metrics,
    ProjectStatusResponse, ReplicaStatus, ServiceStatus, and ServiceState
    structs
  • Added InferFunctionPermissions field to ConfigHasuraSettings and
    ConfigHasuraSettingsUpdateInput structs
  • Removed unused enum ServiceState and its related functions
  • +2/-89   
    Dependencies
    go.mod
    Update Nhost BE dependency                                                             

    go.mod

  • Updated dependency github.com/nhost/be to version
    v0.0.0-20240909133931-ac84bc8054d6
  • +1/-1     
    go.sum
    Update Go module checksums                                                             

    go.sum

    • Added checksum for new version of github.com/nhost/be
    +2/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @github-actions github-actions bot added the fix label Sep 9, 2024
    Copy link
    Contributor

    github-actions bot commented Sep 9, 2024

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Code Removal
    Several structs and enums have been removed. Ensure this doesn't break any existing functionality.

    New Field
    New InferFunctionPermissions field added to ConfigHasuraSettings and ConfigHasuraSettingsUpdateInput structs. Verify if this change is intentional and properly handled in the codebase.

    Dependency Update
    The github.com/nhost/be dependency has been updated. Ensure compatibility with the new version.

    Copy link
    Contributor

    github-actions bot commented Sep 9, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Update dependency version to the latest commit hash

    Update the version of the github.com/nhost/be dependency to the latest commit hash
    for consistency with other dependencies and to ensure you're using the most recent
    version.

    go.mod [17]

    +github.com/nhost/be v0.0.0-20240909133931-ac84bc8054d6
     
    -
    Suggestion importance[1-10]: 10

    Why: The suggestion accurately reflects the change made in the PR, updating the dependency to the latest commit hash, which is a good practice for version control.

    10
    Maintainability
    Remove older versions of a dependency to maintain a clean dependency list

    Remove the older versions of the github.com/nhost/be dependency to keep only the
    latest version in the go.sum file. This helps maintain a cleaner dependency list and
    avoids potential conflicts.

    go.sum [515-522]

    -github.com/nhost/be v0.0.0-20240908163314-496619d1918a h1:3+feiRHyXSfWb1DRdk8DePL377tOQ2dA6vAYU8k3fys=
    -github.com/nhost/be v0.0.0-20240908163314-496619d1918a/go.mod h1:66uhAK6GsdrY7fv2oOQaBAKzMQO0p/pGuf12YuXNHSs=
    -github.com/nhost/be v0.0.0-20240909125313-7c9f5c9566d0 h1:nGocbayWSf+PivZLt06Si/8+dLMyf+U6vi/me+1hQDQ=
    -github.com/nhost/be v0.0.0-20240909125313-7c9f5c9566d0/go.mod h1:fnA4FCHOZpOIdUCXvHBav8KhvHEc2bd+xjDDJq+j+To=
    -github.com/nhost/be v0.0.0-20240909130456-6e51b7cb8f1c h1:Q8ZFSWvmU/l1/YiIfdrMk2pZ/yZQFiG1abJqXZByq4o=
    -github.com/nhost/be v0.0.0-20240909130456-6e51b7cb8f1c/go.mod h1:fnA4FCHOZpOIdUCXvHBav8KhvHEc2bd+xjDDJq+j+To=
     github.com/nhost/be v0.0.0-20240909133931-ac84bc8054d6 h1:/JEKTGU1epbT40S56gHIxgx7cQ0mj6l1varORuedhgw=
     github.com/nhost/be v0.0.0-20240909133931-ac84bc8054d6/go.mod h1:fnA4FCHOZpOIdUCXvHBav8KhvHEc2bd+xjDDJq+j+To=
     
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies the need to clean up older versions of the dependency, which improves maintainability and reduces potential conflicts.

    8

    @dbarrosop dbarrosop merged commit 48b48d7 into main Sep 9, 2024
    10 checks passed
    @dbarrosop dbarrosop deleted the fix branch September 9, 2024 13:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants