Skip to content

Commit

Permalink
Updated cran-comments and NEWS
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Mainey committed Sep 30, 2021
1 parent 993f022 commit 89692c1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# FunnelPlotR 0.4.1

- Bug-fix release: the outlier function was not passing the 'multiplier' argument and was wrong with anything except the default values. This has been corrected to pass the multiplier properly.

# FunnelPlotR 0.4.0

- Major tidy up of the UI, inputs, and control options. This is was to remove inconsistency and help with future development.
Expand Down
3 changes: 1 addition & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## Release summary
This is a major update release for the FunnelPlotR package, changing several arguments to the core function for consistency, adding new functionality, and correcting errors in control limit calculations. All replaced function arguments are soft deprecated, and documented.
This is a bug-fix release for the FunnelPlotR package, as a labelling function was not passing a 'multiplier' argument correctly, and was wrong when anything except the default value was used. This is a key function, as one common metric that uses these plots is generally multiplied by 100.

## Test environments
* local windows 10, R 4.1.1
Expand All @@ -22,7 +22,6 @@ This is a major update release for the FunnelPlotR package, changing several arg
## R CMD check results
There were no ERRORs or WARNINGs.

NOTE concerning new maintainer is a change of email address for the old maintainer after changing role.
NOTEs for 'possibly invalid URL' have all been checked and are valid.


Expand Down
2 changes: 1 addition & 1 deletion dev/tests.R
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ fp2<-funnel_plot(denominator=medpar$prds,numerator=medpar$los, multiplier = 100,
group = medpar$provnum, limit=99
,label = "both"

, sr_method = "CQC",
, sr_method = "SHMI",
draw_unadjusted = FALSE, draw_adjusted=TRUE, highlight = "030002", theme=funnel_grey(),
plot_cols = c("#FF7F0EFF", "#000000", "#1F77B4FF","#1F77B4FF", "#9467BDFF", "#9467BDFF", "#2CA02CFF", "#2CA02CFF"))

Expand Down

0 comments on commit 89692c1

Please sign in to comment.