Skip to content

Commit

Permalink
Updated news and cran comments, removed lazydata from Description
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Mainey committed Sep 14, 2021
1 parent bb6ac90 commit f1179e9
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 22 deletions.
6 changes: 2 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
Package: FunnelPlotR
Type: Package
Title: Funnel Plots for Comparing Institutional Performance
Version: 0.4.9999
Version: 0.4.0
Authors@R: c(
person("Chris", "Mainey", ,"c.mainey@nhs.net", role= c("aut", "cre"),
comment = c(ORCID ="0000-0002-3018-6171")
),
person("Andrew", "Johnson", ,"Andrew.Johnson@health.wa.gov.au", role="ctb",
comment = c(ORCID ="0000-0002-3018-6171")
person("Andrew", "Johnson", ,"Andrew.Johnson@health.wa.gov.au", role="ctb"
),
person("Matthew", "Bass", ,"matthew.bass@uhb.nhs.uk", role="ctb")
)
Expand All @@ -18,7 +17,6 @@ License: MIT + file LICENSE
URL: https://chrismainey.github.io/FunnelPlotR/, https://github.com/chrismainey/FunnelPlotR
BugReports: https://github.com/chrismainey/FunnelPlotR/issues
Encoding: UTF-8
LazyData: true
Imports: dplyr,
ggrepel,
ggplot2,
Expand Down
11 changes: 8 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# FunnelPlotR 0.4.2

Major tidy up of the UI, inputs and the control. This is was to avoid inconsistency and help
# FunnelPlotR 0.4.0

- Major tidy up of the UI, inputs, and control options. This is was to remove inconsistency and help with future development.
- Several arguments renamed, all old arguments should show deprecation warnings and are documented in help files. Notably:
- `Poisson_limits` and `OD_adjusted` are now `draw_unadjusted` and `draw_adjusted`.
- `label_outliers` is now `label` with with more options for labelling rules.
- New argument to highlight data points added.
- Correction for non-monotonic transformation of limits for proportions. Thanks @andrjohns.


# FunnelPlotR 0.3.2
Expand Down
27 changes: 12 additions & 15 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,29 @@
## Release summary
This is a minor release for the FunnelPlotR package, correcting a bug in the way one set of control limits were calculated, plus a several small typos in support material..
This is a major update release for the FunnelPlotR package, changing several arguments to the core function for consistency, adding new functionality, and correcting errors in control limit calculations. All replaced function arguments are soft deprecated, and documented.

## Test environments
* local windows 10, R 4.0.3
* Windows, R devel 2020-09-09 r79174, on Win-builder
* Ubuntu 16.04.6 LTS (on travis-ci), R 4.0.2
* local windows 10, R 4.1.1

* R-devel, on Win-builder

* GitHub actions:
* Mac OS x 10.15.7, R 4.0.3
* Windows Server x64 2019, R 4.0.3
* Mac OS x 10.15.7 19H1323, R 4.1.1
* Windows Server x64 2019, R 4.1.1
* Windows Server x64 latest, R 3.6.3
* Ubuntu 16.04.07, R-devel 2020-11-27 r79522
* Ubuntu 16.04.07, R 4.0.3
* Ubuntu 16.04.07, R 3.6.3
* Ubuntu 16.04.07, R 3.5.3
* Ubuntu 16.04.07, R 3.4.4
* Ubuntu 16.04.07, R 3.3.3
* Ubuntu 20.04.3 LTS, R-devel 2021-09-11 r80887
* Ubuntu 20.04.3 LTS, R 4.1.1

* r-hub:
* Ubuntu Linux 16.04 LTS, R-release, GCC
* Ubuntu Linux 20.04.1 LTS, R-release, GCC
* x86_64-pc-linux-gnu
* Fedora Linux, R-devel, clang, gfortran
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit

## R CMD check results
There were no ERRORs or WARNINGs.

NOTE on Win-builder for possibly invalid URL. URL was checked and is valid.
NOTE on R-Hub Fedora: checking for future file timestamps - unable to verify current time
NOTE concerning new maintainer is a change of email address for the old maintainer after changing role.
NOTEs for 'possibly invalid URL' have all been checked and are valid.


## Downstream dependencies
Expand Down

0 comments on commit f1179e9

Please sign in to comment.