Skip to content

Commit

Permalink
changes from CRAN checks and new Rhub process
Browse files Browse the repository at this point in the history
  • Loading branch information
chrismainey committed Apr 11, 2024
1 parent 302f684 commit f862bc7
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 22 deletions.
3 changes: 1 addition & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Suggests:
rmarkdown,
COUNT,
tidyr,
covr,
Cairo
covr
VignetteBuilder: knitr
Config/testthat/edition: 3
17 changes: 9 additions & 8 deletions R/funnel_plot.R
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,15 @@
#' @param limit Plot limits, accepted values are: 95 or 99, corresponding to 95\% or 99.8\% quantiles of the distribution. Default=99,and applies to OD limits if both OD and Poisson are used.
#' @param label Whether to label outliers, highlighted groups, both or none. Default is "outlier", by accepted values are:\cr
#' \itemize{
#' \item{\code{"outlier"}}{ - Labels upper and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"outlier_lower"}}{ - Labels just and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"outlier_upper"}}{ - Labels just upper, determined in relation to the `limit` argument.}
#' \item{\code{"highlight"}}{ - Labels the value(s) given in the `highlight`argument.}
#' \item{\code{"both"}}{ - Labels both the highlighted values(s), upper and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"both_lower"}}{ - Labels both the highlighted values(s) and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"both_upper"}}{ - Labels both the highlighted values(s) and upper outliers, determined in relation to the `limit` argument.}
#' \item{\code{NA}}{ - No labels applied}}
#' \item{\code{"outlier"} - Labels upper and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"outlier_lower"} - Labels just and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"outlier_upper"} - Labels just upper, determined in relation to the `limit` argument.}
#' \item{\code{"highlight"} - Labels the value(s) given in the `highlight`argument.}
#' \item{\code{"both"} - Labels both the highlighted values(s), upper and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"both_lower"} - Labels both the highlighted values(s) and lower outliers, determined in relation to the `limit` argument.}
#' \item{\code{"both_upper"} - Labels both the highlighted values(s) and upper outliers, determined in relation to the `limit` argument.}
#' \item{\code{NA} - No labels applied}
#' }
#' @param highlight Single or vector of points to highlight, with a different colour and point style. Should correspond to values specified to `group`. Default is NA, for no highlighting.
#' @param label_outliers Deprecated. Please use the `label` argument instead.
#' @param Poisson_limits Deprecated. Please use the `draw_unadjusted` argument instead.
Expand Down
1 change: 0 additions & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ knitr::opts_chunk$set(
comment = "#>",
fig.path = "man/figures/README-",
out.width = "100%",
dev.args = list(png = list(type = "cairo")),
fig.retina=3
)
Expand Down
8 changes: 5 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Resolved 2 CRAN checks NOTES: lost braces in a file due to line breaks, and rena
## Test environments
* local windows 10, R 4.3.2

* R-devel, on Win-builder
* R-devel and release, on Win-builder

* GitHub actions:
* Mac OS x 12.7.4 21H123, R 4.3.3
Expand All @@ -20,8 +20,10 @@ Resolved 2 CRAN checks NOTES: lost braces in a file due to line breaks, and rena
* Ubuntu 20.04.6 LTS, R-devel 2023-05-31
* Ubuntu 20.04.6 LTS, R 4.3.3

* r-hub:
* Ubuntu Linux 20.04.1 LTS, R-release, GCC
* r-hub v2 via GitHub actions:
* Ubuntu Linux 22.04.4 LTS, R-release, GCC
* Ubuntu-clang Linux 20.04.4 LTS, R-devel - failed due to errors with Cairo device on platform
* Mac OS-arm x 14.4.1 23E224, R 4.3.3 - failed due to cache issues on platform, and Cairo device.
* Fedora Linux, R-devel, clang, gfortran
* Windows Server 2022, R-devel, 64 bit

Expand Down
Binary file modified man/figures/README-funnel1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-funnel2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 9 additions & 8 deletions man/funnel_plot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f862bc7

Please sign in to comment.