Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process for installing eleveldb is as follows:
eleveldb/rebar.config
Lines 33 to 34 in 251f432
get-deps
andcompile
c_src/system/lib
andc_src/system/include
where the snappy compression code will be heldget_deps
stage.compile
stage, initially Snappy is compiled, into thec_src/systerm
directoryeleveldb/c_src/Makefile
Lines 36 to 43 in 251f432
leveldb/build_detect_platform
script to create abuild_config.mk
to be used in this make process - https://github.com/nhs-riak/leveldb/blob/2fd90c712af1ac9609ef9c1adba98814fb6751ef/Makefile#L18-L23build_config.mk
file complete and included, the Makefile will then make leveldb using https://github.com/nhs-riak/leveldb/blob/2fd90c712af1ac9609ef9c1adba98814fb6751ef/Makefile#L86pre-hook
is done, and so eleveldb is compiled using thepost
provider_hookeleveldb/rebar.config
Lines 7 to 16 in 251f432
The issues this PR addresses are:
eleveldb/c_src/Makefile
means that those flags were not set for downstream Makefiles, and so the test for snappy presence would not compile due to the absence of the include directives in the CFLAGSbuild_detect_platform
(for compiling snappy/leveldb) and therebar.config.script
(for compiling eleveldb)