Change argument passing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenwood24-nhs
approved these changes
May 15, 2024
otherwise calling 'riak admin bucket-type create type "{\"props\": {\"datatype\":\"map\"} }"'
or other riak commands with quoted arugments which contain whitespace would fail
leonross-nhs
approved these changes
May 20, 2024
|
@hmmr - this is in our repo not basho, but would this present any obvious issues to you? We need the PR to sort issues with spaces in riak commands (e.g. within JSON for bucket properties, or in riak eval) |
|
As long as it works, I'll gladly accept your way of shaving this little yak. I'm also happy to see someone remove this line and the mystery of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested ... the riak admin console tests do their own mangling on spaces :-(