Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action link in a Care card (Immediate) #588

Closed
davidhunter08 opened this issue Feb 25, 2020 · 4 comments · Fixed by #706
Closed

Action link in a Care card (Immediate) #588

davidhunter08 opened this issue Feb 25, 2020 · 4 comments · Fixed by #706
Labels
accessibility Accessibility related action link 🕙 hours A well understood issue which we expect to take less than a day to resolve ⚠️ high priority Used by the team when triaging
Milestone
5.0.0

Comments

@davidhunter08
Copy link
Contributor

When using an action link inside an immediate care card, the green action link icon does not have sufficient contrast with the black background.

Screenshot 2020-02-25 at 12 00 13
@davidhunter08 davidhunter08 added accessibility Accessibility related component 🕙 hours A well understood issue which we expect to take less than a day to resolve ⚠️ high priority Used by the team when triaging labels Feb 25, 2020
@andrewbarnesweb
Copy link
Contributor

It's only just missing at 2.8 with a target of 3 🙁: https://snook.ca/technical/colour_contrast/colour.html#fg=007F3B,bg=212B32FFFFFF

The only other "green" I can see in the palette is: $color_nhsuk-aqua-green. Which gives you a 4.6: https://snook.ca/technical/colour_contrast/colour.html#fg=00A499,bg=212B32FFFFFF

image

@chrimesdev
Copy link
Member

chrimesdev commented Mar 19, 2020 •
edited
Loading

Few other design options...

$color_nhsuk-white - 14.42 (https://snook.ca/technical/colour_contrast/colour.html#fg=FFFFFF,bg=212B32)

Screenshot 2020-03-19 at 14 33 41

$color_nhsuk-red - 2.84
(https://snook.ca/technical/colour_contrast/colour.html#fg=D5281B,bg=212B32)

Screenshot 2020-03-19 at 14 34 49

$color_nhsuk-yellow - 11.809
(https://snook.ca/technical/colour_contrast/colour.html#fg=FFEB3B,bg=212B32)

Screenshot 2020-03-19 at 14 36 35

@mcheung-nhs
Copy link
Collaborator

These are what the various colours look like when in high contrast mode in Windows

action-link-emergency-high-contrast-windows

and in Chrome using the high contrast plugin

action-link-emergency-high-contrast-chrome

@chrimesdev chrimesdev added this to the 5.0.0 milestone Jan 20, 2021
@davidhunter08
Copy link
Contributor Author

$color_nhsuk-white looks to be the best option.

chrimesdev added a commit that referenced this issue Feb 19, 2021
@chrimesdev
[refs #588] give the Action link icon sufficient contrast when used i…
89500f9 
…n the Care card immediate variant

Body (72 chars)
chrimesdev added a commit that referenced this issue Feb 19, 2021
@chrimesdev
[refs #588] Action link icon contrast in the immediate Care card
d59e048 
Give the Action link icon sufficient contrast when used in the Care card immediate variant
chrimesdev added a commit that referenced this issue Feb 19, 2021
@chrimesdev
[refs #588] Action link icon contrast in the immediate Care card
876311b 
Give the Action link icon sufficient contrast when used in the Care card immediate variant
@chrimesdev chrimesdev mentioned this issue Feb 19, 2021
Merged
3 tasks
@chrimesdev chrimesdev mentioned this issue Jul 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Accessibility related action link 🕙 hours A well understood issue which we expect to take less than a day to resolve ⚠️ high priority Used by the team when triaging
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Action link icon contrast in the immediate Care card nhsuk/nhsuk-frontend
4 participants
@mcheung-nhs @chrimesdev @davidhunter08 @andrewbarnesweb