-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update arrow icons to be visually consistent with other arrow-like icons #1027
base: main
Are you sure you want to change the base?
Conversation
@paulrobertlloyd ooh I like this, it looks a lot more consistent! It's interesting how one of the main style differences between govuk and nhs, eg on buttons and arrows, is sharp corners vs rounded corners 😄 Do you think it’s worth exploring whether the pagination component could even use the chevron variant without the horizontal line? The 'Previous' and 'Next' titles could then perhaps be aligned (left and right) with the page titles underneath? |
I agree the new arrows seem more visually in keeping with general styles. Nice work. |
Possibly, although I like the greater directionality (spoken like a true designer) of the arrows versus the chevrons. Aligning the text would be a good call, be good to tidy up the alignment a bit. |
made-up phrase 😉 Whilst we’re here, let’s talk colours? Existing behaviour:
A bit inconsistent, but possibly with good reason? In general, I think it’s good if there can be some indication on hover that the icon is part of the link - but that could be a background colour change (govuk pagination links use a background grey colour on hover) or an icon fill colour change? |
For the colouranality (😉), maybe we can have some rules around this; such as when an item is hovered, active or focused, all elements within that link share the same standard link colours for these states? |
This sent me down a rabbithole trying to work out where the standalone |
Description
In reviewing #1026, the difference in arrows used for pagination versus chevrons used in other components and the right-pointing action link icon becomes clearer, with the pagination arrows looking like they are from a different icon set.
Also, with the numbered pagination option, it looks like the arrows might be rendered smaller; at which point the arrow tips become harder to identify.
This PR update the pagination arrow icons to have open arrow tips, using the same path metrics as those used by the other arrow icons.
This could also potentially be merged into and be part of #1026, or merged separately (with corresponding a changelog entry).
Pagination before
Pagination after
Arrow icons before
Arrow icons after
Checklist