remove random margin-top from the Menu button on Safari #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimesdev
force-pushed
the
fix/safari-button-margin
branch
3 times, most recently
from
795ea79 to
5f8bf4d
Compare
On screen sizes between the table and large-desktop breakpoints, there is a random 1 pixel margin-top on the Menu button in Safari. This makes the button unaligned with the search bar.
chrimesdev
changed the title
chrimesdev
force-pushed
the
fix/safari-button-margin
branch
from
5f8bf4d to
ec88f74
Compare
davidhunter08
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On screen sizes between the table and large-desktop breakpoints, there is a random 1 pixel margin-top on the Menu button in Safari. This makes the button unaligned with the search bar.
This isn't an issue on Chrome or Firefox
Setting margin-top to 0 between the table and large-desktop breakpoints fixes the issue on Safari and has no affect on other browsers.
Checklist