Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to guides: Branching example - inconsistent header & footer #71

Closed
chrimesdev opened this issue Feb 19, 2019 · 0 comments
Closed

How to guides: Branching example - inconsistent header & footer #71

chrimesdev opened this issue Feb 19, 2019 · 0 comments

Comments

@chrimesdev
Copy link
Member

When using the Branching example, the Header and Footer aren't consistent throughout the journey.

You start with a transactional header with service name and a footer with 2 links in it.
https://nhsuk-prototype-kit.azurewebsites.net/examples/branching

But then get a page with a normal header with no service name and a footer with 0 links in it.
https://nhsuk-prototype-kit.azurewebsites.net/examples/branching/answer-yes
https://nhsuk-prototype-kit.azurewebsites.net/examples/branching/answer-no
chrimesdev added a commit that referenced this issue Feb 21, 2019
@chrimesdev
[refs #71] Use consistent header and footer for branching example pages
60d6ef2
davidhunter08 added a commit that referenced this issue Feb 21, 2019
@davidhunter08
Merge pull request #76 from nhsuk/fix/header-footer-consistency
92335ad 
[refs #71] Use consistent header and footer for branching example pages
@davidhunter08 davidhunter08 mentioned this issue Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrimesdev @davidhunter08