Mark the NI C# Analyzers package as a development dependency

[nick-beer]

Justification

This NuGet package only provides analyzers, and so should be marked as a development dependency. This enables tooling to automatically exclude compile time assets, as well as prevent this package from being brought along as a dependency of other packages. See here.

When marked as a development dependency, NuGet.org updates its PackageReference suggestion to include PrivateAssets and IncludeAssets tags - like the following:

<PackageReference Include="xunit.analyzers" Version="1.15.0">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>

Implementation

Mark developmentDependency = true in the .nuspec file.

Testing

Built the nuget package locally, and verified it is marked as a development dependency: