Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return supported event types when opening a session #1000

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

dmondrik
Copy link
Contributor

@dmondrik dmondrik commented Sep 21, 2023

What does this Pull Request accomplish?

  • It includes the supported events for a newly-opened session as part of the "Open" response.
  • This copies the latest output from scrapigen. The update is in a pending PR there.

Why should this Pull Request be merged?

The VISA client needs to know which event types are supported for a given session.

What testing has been done?

  • Built and walked through it in the debugger.
  • I updated the integration tests to account for the new library calls. Added both success and failure cases.

@dmondrik dmondrik changed the title Return supported events when opening a session Return supported event types when opening a session Sep 21, 2023
@reckenro
Copy link
Collaborator

FYI main is locked as the release is finalized on AzDo / we bump the grpc-device version on the AzDo side for new exports. This should be resolved early next week. Alex, Maxx, or I can then unlock main here in grpc-device.

@reckenro
Copy link
Collaborator

Main is unlocked now.

@dmondrik dmondrik merged commit 7d4dbb1 into main Sep 25, 2023
9 of 11 checks passed
@dmondrik dmondrik deleted the users/danrm/open-events branch September 25, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants