(2.6 patch) Fix recvfrom never populating from_addr due to fromlen being zero #1108
Conversation
* Update all download-artifact uses to v4 * Update upload-artifact to v4 --------- Co-authored-by: Maxx Boehme <maxx.boehme@ni.com>
Co-authored-by: Maxx Boehme <maxx.boehme@ni.com>
CMakeLists.txt
Outdated
| @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.12.0) | |||
|
|
|||
| project(ni_grpc_device_server | |||
| LANGUAGES C CXX | |||
| VERSION 2.6.0) | |||
| VERSION 2.7.0) | |||
There was a problem hiding this comment.
@maxxboehme i noticed that you bumped the version here. do you expect to make this fix in the main branch instead of releases/2.6.0?
There was a problem hiding this comment.
@yaqian256 , I had cherry picked this accidentally, I will revert it in this PR.
I initially only changed functions.py but ran into errors on the pipeline saying some of the github actions used were outdated. I ended up cherry picking relevant changes from main but looks like I included the cmake changes incorrectly.
|
@maxxboehme i also created #1109 (it requires the repo admin to enable), if the bot is enabled, it can help us update github action versions. |
|
@jonathanou is a release patch necessary? Our process does not currently work well for patch releases of grpc-device and it causes havoc with the internal pipelines kicked off for azdo. Preferably would either have
|
What does this Pull Request accomplish?
TODO: Include high-level description of the changes in this pull request.
Why should this Pull Request be merged?
TODO: Justify why this contribution should be part of the project.
What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.