adding fake fpga tests to test fpga streaming apis #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asumit
requested review from
reckenro,
astarche and
maxxboehme
as code owners
mwrging latest changes from main
astarche
reviewed
Nov 21, 2024
| stream->Read(&read_result); | ||
|
|
||
| read_result.data().values(0).UnpackTo(&read_value_i32); | ||
| EXPECT_EQ(read_value_i32.value(), i + 1); |
There was a problem hiding this comment.
When we talked on the phone, I think this assert was not working? What was the problem? What fixed it?
There was a problem hiding this comment.
I set the .WillRepeatedly(::testing::DoAll(::testing::SetArgPointee<2>(999), ::testing::Return(0))); on the mock api after 5 counts and after that it is passing locally everytime.
I spoke to Cifra and the read should behave like a queue and no data points should be missed. I am not sure if it was simultaneous debugging the streaming api and the client that may have caused it but it works now.
astarche
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds tests to test various streaming apis for fpga. We use NiFpgaMockLibrary to set the behavior of fpga driver apis.
Tests in this class are testing the streaming api implementation and the data moniker service code.
What testing has been done?
Ran the tests locally and they pass
Note : I have added tests for sideband streaming and disabled it since currently we cannot test the sideband streaming apis with the inprocess