-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-personality RFmx examples. #912
Conversation
Signed-off-by: Gerardo Orozco <gorozco@ni.com>
Thank you Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>
Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>
Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>
Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just some small tweaks needed and questions.
Also, before you submit make sure to update the PR title.
We are branching for the 2.2 release, this change has open conversations and potentially conflicts with #878 . I recommend we wait to submit this after the release |
Trying to get this example in the release at some point. Co-authored-by: Ryan Eckenrode <77176215+reckenro@users.noreply.github.com>
…pc-device into users/gorozco/multisession
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finishing my review.
Does anyone know why this failed? |
@yardov, I didn't know a good way to type it out, but I was able to run it locally and have potential fixes for the MyPy complaints. I created a draft PR #996. I put in the Description of that PR how I run validate_examples.py locally to get the same results as the CI build on PRs. And then you can see the diff for this file I made here. Those changes at least satisfy MyPy, but I'm not sure if all of the changes are correct for your example. I also merged main before making any changes so you can ignore all the commits except those last three I linked the diff to. |
Hi Ryan, thank you for your comments and detail PR. I am going over the changes... _C:\github\grpc-device\grpc-device\examples>python ..\source\codegen\validate_examples.py -p "*nirf" -- Validating: nirf |
Sure thing! And did you run |
Great! |
What does this Pull Request accomplish?
How to mix multiple RFmx personalities using gRPC. It was not clear to me before if we needed to initialize each personality and keep track of the instrument variable.
Why should this Pull Request be merged?
Show customers how to do this programming.
What testing has been done?
Simple execution of the code. This mixes other two existing examples in the same one.