-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TypeScript Rules (without requiring type checking rules) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
commented
Jan 21, 2021
jattasNI
requested changes
Jan 27, 2021
LukasKall
reviewed
Jan 28, 2021
jattasNI
requested changes
Jan 29, 2021
LukasKall
reviewed
Jan 29, 2021
jattasNI
requested changes
Jan 29, 2021
jattasNI
requested changes
Jan 29, 2021
If anyone else is doing this on a Mac, note that the built-in Archive Utility seems to try to recursively unpackage files. So I was very confused as to where |
LukasKall
reviewed
Feb 4, 2021
mure
reviewed
Feb 4, 2021
mure
reviewed
Feb 11, 2021
TrevorKarjanis
requested changes
Feb 12, 2021
TrevorKarjanis
requested changes
Feb 17, 2021
jattasNI
approved these changes
Mar 11, 2021
TrevorKarjanis
approved these changes
Mar 11, 2021
LukasKall
approved these changes
Mar 12, 2021
@mure I'll go ahead and merge this since we have most reviewers. If you have feedback we can address it in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to be used for evaluating the TypeScript Rules used in
typescript.js
.To test locally, you can add the devDependencies to a project with:
And extract the tgz from the npm package build artifact (see below) and run:
This PR also makes a few additional changes:
npm run dev-print-typescript-props
to print the properties expected in each of the TypeScript configurations based on the installed typescript-eslint version. This helps in maintenance of tracking changes to the typescript-extension rules.Build artifacts: