Skip to content

Commit

Permalink
Expose new table labels in Blazor (#1556)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

The new labels added in #1519 need to be exposed in Blazor

## πŸ‘©β€πŸ’» Implementation

Followed existing pattern to expose and test new labels

## πŸ§ͺ Testing

Ran unit tests

## βœ… Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [ ] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
mollykreis authored Sep 22, 2023
1 parent 2c90116 commit 59d65d5
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Expose new table labels in Blazor",
"packageName": "@ni/nimble-blazor",
"email": "20542556+mollykreis@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,11 @@
groups-collapse-all="@GroupsCollapseAll"
cell-action-menu="@CellActionMenu"
column-header-grouped="@ColumnHeaderGrouped"
column-header-sorted-ascending="@ColumnHeaderSortedAscending"
column-header-sorted-descending="@ColumnHeaderSortedDescending"
select-all="@SelectAll"
group-select-all="@GroupSelectAll"
row-select="@RowSelect"
row-operation-column="@RowOperationColumn"
@attributes="AdditionalAttributes">
</nimble-label-provider-table>
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,24 @@ public partial class NimbleLabelProviderTable : ComponentBase
[Parameter]
public string? ColumnHeaderGrouped { get; set; }

[Parameter]
public string? ColumnHeaderSortedAscending { get; set; }

[Parameter]
public string? ColumnHeaderSortedDescending { get; set; }

[Parameter]
public string? SelectAll { get; set; }

[Parameter]
public string? GroupSelectAll { get; set; }

[Parameter]
public string? RowSelect { get; set; }

[Parameter]
public string? RowOperationColumn { get; set; }

/// <summary>
/// Gets or sets a collection of additional attributes that will be applied to the created element.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ public void NimbleLabelProviderTable_SupportsAdditionalAttributes()
[InlineData(nameof(NimbleLabelProviderTable.GroupsCollapseAll))]
[InlineData(nameof(NimbleLabelProviderTable.CellActionMenu))]
[InlineData(nameof(NimbleLabelProviderTable.ColumnHeaderGrouped))]
[InlineData(nameof(NimbleLabelProviderTable.ColumnHeaderSortedAscending))]
[InlineData(nameof(NimbleLabelProviderTable.ColumnHeaderSortedDescending))]
[InlineData(nameof(NimbleLabelProviderTable.SelectAll))]
[InlineData(nameof(NimbleLabelProviderTable.GroupSelectAll))]
[InlineData(nameof(NimbleLabelProviderTable.RowSelect))]
[InlineData(nameof(NimbleLabelProviderTable.RowOperationColumn))]
public void NimbleLabelProviderTable_LabelIsSet(string propertyName)
{
var labelValue = propertyName + "UpdatedValue";
Expand Down

0 comments on commit 59d65d5

Please sign in to comment.