-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
nimble-text-area should allow setting width (#457)
## 🤨 Rationale The `nimble-text-area` cannot be made to stretch to fill the width of its container. Or rather, the contained `textarea` does not obey the width set on the `nimble-text-area`. ## 👩💻 Implementation Setting `width` to `inherit` on the `textarea` (class `control`) causes it to inherit any `width` value set on the `nimble-text-area` element. Note that `nimble-text-area` also supports controlling the visible width via a `cols` attribute (number of visible text columns). When the `width` style is set, this overrides the `cols` attribute. ## 🧪 Testing Tested manually in dev tools. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
- Loading branch information
Showing
3 changed files
with
76 additions
and
2 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-3d1e9025-e654-496f-a304-152c399e5016.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "nimble-text-area honor height and width", | ||
"packageName": "@ni/nimble-components", | ||
"email": "7282195+m-akinc@users.noreply.github.com", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters