-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select and Combobox Refresh #1303
Comments
First priorities in cycle 3: |
Interaction design requests
|
…1432) # Pull Request ## 🤨 Rationale I was given the feedback that our existing docs for the combobox are confusing and misleading because we only document the behavior of the native element without any additional documentation that explains the behavior in our supported frameworks (or even implies that the API behavior might be different). It is also not ideal that our previous "recommended" workflow for reading the value associated with an `OPTION_NOT_FOUND` Angular combobox was through the `nativeElement`. Therefore, I've added a getter for the `value` in Angular. I expect that at least part of the documentation and implementation will need to be updated when all the issues captured in #1303 are addressed, but I think this change is still good to enable clients to be more successful with the combobox before a more complete fix is in place. Fixes #682 ## 👩💻 Implementation - Add getter for `value` on the Angular combobox directive - Created `.mdx` story for the comboxbox so that we can create docs with improved formatting. ## 🧪 Testing - Manually verified that the doc page looks correct. - New unit tests for reading the `value` of a combobox from Angular ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed.
Currently due to lack of label on select component it is looking out of place when used alongside other components. |
@leslieab, I've added a new bullet item to the description for tracking a decision on whether we should offer a means for a client to configure the height of the dropdown. We've now seen a couple of requests for this, but aren't currently tracking that particular aspect in a dedicated issue. |
# Pull Request ## 🤨 Rationale For #1303 - Select and Combobox Refresh HLD - Interaction design specification for select component ## 👩💻 Implementation N/A ## 🧪 Testing N/A ## ✅ Checklist - [X] Submit project documentation - [x] Review - [ ] Update project documentation --------- Co-authored-by: mollykreis <20542556+mollykreis@users.noreply.github.com> Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com> Co-authored-by: Milan Raj <rajsite@users.noreply.github.com> Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
# Pull Request ## 🤨 Rationale For #1303 - Select and Combobox Refresh HLD - Interaction design specification for combobox component ## 👩💻 Implementation N/A ## 🧪 Testing N/A ## ✅ Checklist - [X] Submit project documentation - [x] Review - [ ] Update project documentation --------- Co-authored-by: Jonathan Meyer <26874831+atmgrifter00@users.noreply.github.com> Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com> Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
📌 User Story
The following are topics that should be addressed (included or closed):
Both:
"Load more" / "Show all" / Action button / Checkbox (use case: dynamic loading of additional options)More filter optionsCase sensitiveListOption
to contain complex content #1135 NimbleListOption content in start slot is top-aligned #1254Slottable content in selector area: Show prefix information in select / combobox #1310Editable options (add new entries): Add dynamic option in dropdown of combobox #507Context menu key interactions: Menu key in combobox does not open the browser native context menu #798Virtualization of options: [Blazor] Nimble dropdowns have noticeable update lag when scrolling. #710Visual when used in table: Input table columns (select, text field, etc) #1190Select:
NimbleSelect
. #1273Multiselect: Create Nimble Filterable select with Multi-select #341will implement as a picker componentCombobox:
Autocomplete mode that allows searching any part of the string: Combobox filter option to match input to any part of dropdown options #535Stop alteringhidden
state of options: Combobox should stop alteringhidden
state of options #1902The text was updated successfully, but these errors were encountered: