Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select and Combobox Refresh #1303

Closed
6 of 21 tasks
rajsite opened this issue Jun 14, 2023 · 5 comments
Closed
6 of 21 tasks

Select and Combobox Refresh #1303

rajsite opened this issue Jun 14, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@rajsite
Copy link
Member

rajsite commented Jun 14, 2023

📌 User Story

The following are topics that should be addressed (included or closed):

Both:

Select:

Combobox:

@rajsite rajsite added the triage New issue that needs to be reviewed label Jun 14, 2023
@jattasNI jattasNI removed the triage New issue that needs to be reviewed label Jun 20, 2023
@jattasNI
Copy link
Contributor

First priorities in cycle 3:

  1. Sectioned Select #791
  2. Filterable NimbleSelect. #1273

@jattasNI jattasNI added the interaction design Interaction design work item label Jul 28, 2023
@jattasNI
Copy link
Contributor

Interaction design requests

  1. Fill out IxD spec for select / combobox with particular focus on usage guidance (and considering the roadmap laid out in the linked issues above)

mollykreis added a commit that referenced this issue Aug 16, 2023
…1432)

# Pull Request

## 🤨 Rationale

I was given the feedback that our existing docs for the combobox are
confusing and misleading because we only document the behavior of the
native element without any additional documentation that explains the
behavior in our supported frameworks (or even implies that the API
behavior might be different). It is also not ideal that our previous
"recommended" workflow for reading the value associated with an
`OPTION_NOT_FOUND` Angular combobox was through the `nativeElement`.
Therefore, I've added a getter for the `value` in Angular.

I expect that at least part of the documentation and implementation will
need to be updated when all the issues captured in #1303 are addressed,
but I think this change is still good to enable clients to be more
successful with the combobox before a more complete fix is in place.

Fixes #682

## 👩‍💻 Implementation

- Add getter for `value` on the Angular combobox directive
- Created `.mdx` story for the comboxbox so that we can create docs with
improved formatting.

## 🧪 Testing

- Manually verified that the doc page looks correct.
- New unit tests for reading the `value` of a combobox from Angular

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [ ] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@m-akinc m-akinc moved this to Current Iteration in Nimble Design System Priorities Aug 28, 2023
This was referenced Sep 12, 2023
@fredvisser fredvisser changed the title Select and Combobox Refresh HLD Select and Combobox Refresh IxD Spec Oct 9, 2023
@m-akinc m-akinc moved this from Current Iteration to In progress in Nimble Design System Priorities Oct 17, 2023
@SPathani-NI
Copy link

Currently due to lack of label on select component it is looking out of place when used alongside other components.
Also, it is not responding correctly to "width" CSS property current workaround is using "min-width".

@atmgrifter00
Copy link
Contributor

@leslieab, I've added a new bullet item to the description for tracking a decision on whether we should offer a means for a client to configure the height of the dropdown. We've now seen a couple of requests for this, but aren't currently tracking that particular aspect in a dedicated issue.

@m-akinc m-akinc moved this from In progress to Current Iteration in Nimble Design System Priorities Nov 14, 2023
fredvisser added a commit that referenced this issue Dec 12, 2023
# Pull Request

## 🤨 Rationale
For #1303 - Select and Combobox Refresh HLD

- Interaction design specification for select component

## 👩‍💻 Implementation

N/A

## 🧪 Testing

N/A

## ✅ Checklist

- [X] Submit project documentation
- [x] Review
- [ ] Update project documentation

---------

Co-authored-by: mollykreis <20542556+mollykreis@users.noreply.github.com>
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
fredvisser added a commit that referenced this issue Dec 12, 2023
# Pull Request

## 🤨 Rationale

For #1303 - Select and Combobox Refresh HLD
- Interaction design specification for combobox component

## 👩‍💻 Implementation

N/A

## 🧪 Testing

N/A

## ✅ Checklist

- [X] Submit project documentation
- [x] Review
- [ ] Update project documentation

---------

Co-authored-by: Jonathan Meyer <26874831+atmgrifter00@users.noreply.github.com>
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
Co-authored-by: Fred Visser <1458528+fredvisser@users.noreply.github.com>
@fredvisser fredvisser assigned fredvisser and unassigned leslieab Jan 25, 2024
@rajsite rajsite mentioned this issue Feb 14, 2024
1 task
@rajsite rajsite added enhancement New feature or request and removed interaction design Interaction design work item labels Jul 3, 2024
@rajsite rajsite changed the title Select and Combobox Refresh IxD Spec Select and Combobox Refresh Jul 3, 2024
@rajsite
Copy link
Member Author

rajsite commented Jul 4, 2024

Unofficial motto for this issue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

7 participants