Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TypeScript 4.8 #810

Closed
TrevorKarjanis opened this issue Nov 10, 2022 · 2 comments · Fixed by #1599
Closed

Support TypeScript 4.8 #810

TrevorKarjanis opened this issue Nov 10, 2022 · 2 comments · Fixed by #1599
Assignees
@mollykreis @atmgrifter00
Labels
tech debt

Comments

@TrevorKarjanis
Copy link
Contributor

TrevorKarjanis commented Nov 10, 2022 •
edited by rajsite
Loading

🧹 Tech Debt

As per issue 6365, @microsoft/fast-foundation is not compatible with TS 4.8.

We need to support TypeScript 4.8 to support Angular 15 where TS 4.8 is the minimum support version.
@TrevorKarjanis TrevorKarjanis added tech debt triage New issue that needs to be reviewed labels Nov 10, 2022
@TrevorKarjanis TrevorKarjanis mentioned this issue Nov 10, 2022
Merged
1 task
@jattasNI jattasNI added blocked Blocked on a third-party issue and removed triage New issue that needs to be reviewed blocked Blocked on a third-party issue labels Nov 15, 2022
@rajsite rajsite mentioned this issue Feb 1, 2023
Closed
@rajsite rajsite changed the title Remove the TS dependency from the root dependencies. Support TypeScript 4.8 Feb 1, 2023
@jattasNI jattasNI mentioned this issue Feb 23, 2023
Closed
@jattasNI jattasNI mentioned this issue Apr 5, 2023
Merged
1 task
jattasNI added a commit that referenced this issue Apr 5, 2023
@jattasNI
Upgrade to TypeScript 4.7.4 (#1159)
2dd4d31 
# Pull Request

## 🤨 Rationale

Some of the storybook bug fixes in #1146 will likely rely on the
[TypeScript 4.7 support for defining entry points in
package.json](https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing).
While we can't uptake those fixes yet, I want to remove a potential
blocker by moving us from TypeScript 4.6 to 4.7

## 👩‍💻 Implementation

1. Replaced all `package.json` instances of `typescript": "~4.6.4"` with
`typescript": "~4.7.4"`. That's the latest patch on the 4.7 minor
release.
2. Ran `npm install` to regenerate `package-lock.json`

We're not updating to TypeScript 4.8 or 5.0 yet because of blockers like
#810.

## 🧪 Testing

Ran `npm run pack` and brought the `nimble-angular` tgz into
SystemLinkShared. Verified that it still builds and the example app runs
even though that project is on TypeScript 4.6.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@rajsite
Copy link
Member

rajsite commented Jul 31, 2023

FAST has a PR up from a contributor for TypeScript 4.8 support: microsoft/fast#6779

We should try it and see if it can unblock Angular 15+ upgrades.

@mollykreis mollykreis mentioned this issue Aug 11, 2023
Merged
1 task
@m-akinc m-akinc moved this to Current Iteration in Nimble Design System Priorities Aug 15, 2023
@atmgrifter00 atmgrifter00 self-assigned this Sep 8, 2023
@m-akinc m-akinc added the blocked Blocked on a third-party issue label Sep 12, 2023
@m-akinc m-akinc moved this from Current Iteration to In progress in Nimble Design System Priorities Sep 12, 2023
@rajsite
Copy link
Member

rajsite commented Oct 11, 2023

With @microsoft/fast-foundation v2.49.2 which includes changes from microsoft/fast#6779 we should be unblocked by FAST for upgrading the typescript version.

@rajsite rajsite added triage New issue that needs to be reviewed and removed blocked Blocked on a third-party issue labels Oct 11, 2023
@mollykreis mollykreis self-assigned this Oct 13, 2023
@mollykreis mollykreis mentioned this issue Oct 13, 2023
Merged
1 task
mollykreis added a commit that referenced this issue Oct 16, 2023
@mollykreis
Update TypeScript dependency to 4.8 (#1599)
8a42916 
# Pull Request

## 🤨 Rationale

Resolves #810 

## 👩‍💻 Implementation

- Update dependency of `@microsoft/fast-foundation` to the new version
that supports TypeScript 4.8
- Update dependency of TypesScript to 4.8

## 🧪 Testing

- Ran the nimble pipeline
- Used a locally built version of nimble to build SystemLinkShared to
verify an upgrade to a new version of nimble will not immediately cause
any build errors
- Used a locally built version of nimble to build SystemLinkShared with
TypeScript 4.8 to verify that SystemLinkShared can update to TS 4.8 with
this change

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [ ] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@m-akinc m-akinc moved this from In progress to Done in Nimble Design System Priorities Oct 17, 2023
@rajsite rajsite removed the triage New issue that needs to be reviewed label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mollykreis mollykreis

@atmgrifter00 atmgrifter00

Labels
tech debt
Projects
Nimble Design System Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update TypeScript dependency to 4.8 ni/nimble
6 participants
@rajsite @TrevorKarjanis @m-akinc @jattasNI @mollykreis @atmgrifter00