Blazor integration for anchor menu item #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
requested review from
atmgrifter00,
msmithNI,
rajsite and
jattasNI
as code owners
packages/nimble-blazor/Tests/NimbleBlazor.Tests/Unit/Components/NimbleAnchorMenuItemTests.cs
Show resolved
Hide resolved
jattasNI
reviewed
Mar 20, 2023
atmgrifter00
approved these changes
Mar 20, 2023
rajsite
reviewed
Mar 21, 2023
packages/nimble-blazor/NimbleBlazor/Components/NimbleAnchorMenuItem.razor.cs
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Mar 21, 2023
packages/nimble-blazor/Tests/NimbleBlazor.Tests/Unit/Components/NimbleAnchorMenuItemTests.cs
Outdated
Show resolved
Hide resolved
msmithNI
approved these changes
Mar 24, 2023
rajsite
approved these changes
Mar 28, 2023
|
There have been significant changes so pinging a blazor expert to re-review jic @atmgrifter00 |
atmgrifter00
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Blazor support for anchor menu item component
👩💻 Implementation
Followed standard process. Includes test, update to example app, and update to README.
🧪 Testing
Tested via example app
✅ Checklist