Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tables in the Blazor and Angular example apps consistent with each other #1555

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

With #1519, we can re-introduce initial rows to the table in the Angular example app without failing the Lighthouse accessibility check. I decided that this was also a good chance to make the tables in the Blazor and Angular example apps consistent with each other.

Resolves #1195
Resolves #978

👩‍💻 Implementation

Updated the Blazor and Angular example tables to:

  • Use consistent models to represent the table data
    • As part of this, I made the Blazor example app have deterministic data and removed the use of Faker
  • Have the same set of columns and column configuration
  • Load initially with 10 rows
  • Add 10 more rows to the table when the Add rows button is pressed

🧪 Testing

  • Ran both example apps and make sure the tables behave identically and have the same data
  • Verified that the Lighthouse accessibility check passes (part of the pipeline)

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@atmgrifter00, will you buddy this for me?

@mollykreis mollykreis marked this pull request as ready for review September 22, 2023 17:01
@rajsite rajsite enabled auto-merge (squash) September 25, 2023 23:13
@rajsite rajsite merged commit e4e676f into main Sep 25, 2023
@rajsite rajsite deleted the align-table-examples branch September 25, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants