Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run webkit tests on pipeline builds #2237

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Jul 2, 2024

Pull Request

🀨 Rationale

Closes #990

πŸ‘©β€πŸ’» Implementation

I upstreamed a change to karma-webkit-launcher to fix our issues on Linux build machines, and now we're pulling in the fixed release.

πŸ§ͺ Testing

Build runs without hanging. The validation step still takes roughly 6 minutes, even though it is running most of the nimble-components tests an additional time.

[test-concurrent:nimble-components] [test-webkit:verbose] Safari 17.0 (Linux x86_64): Executed 4595 of 4646 (skipped 51) SUCCESS (5 mins 11.218 secs / 4 mins 17.806 secs)

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc requested a review from rajsite July 11, 2024 16:26
@m-akinc m-akinc marked this pull request as ready for review July 11, 2024 16:26
@m-akinc m-akinc requested a review from jattasNI as a code owner July 11, 2024 16:27
@rajsite rajsite enabled auto-merge (squash) July 11, 2024 21:07
@m-akinc
Copy link
Contributor Author

m-akinc commented Jul 11, 2024

No real need for review from @DStavilaNI and @munteannatan -- just skipping two more wafer map tests on Webkit (I updated #2169 with the test names).

@rajsite rajsite merged commit 154703c into main Jul 11, 2024
11 checks passed
@rajsite rajsite deleted the users/makinc/webkit-tests-on-ci branch July 11, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve cross browser test coverage: enable WebKit tests on CI
3 participants