-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix menu item indentation bug with dynamically slotted icons #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mollykreis will you please buddy this change? |
mollykreis
reviewed
Jul 22, 2024
mollykreis
approved these changes
Jul 23, 2024
m-akinc
commented
Jul 26, 2024
m-akinc
commented
Jul 26, 2024
packages/nimble-components/src/menu-button/tests/menu-button.spec.ts
Outdated
Show resolved
Hide resolved
m-akinc
commented
Jul 26, 2024
m-akinc
commented
Jul 26, 2024
m-akinc
commented
Jul 26, 2024
jattasNI
approved these changes
Jul 26, 2024
rajsite
reviewed
Jul 26, 2024
rajsite
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Fixes #2266
π©βπ» Implementation
Proper indentation relies on
startColumnCount
being set on the menu items. This is handled byFoundationMenu.setItems
. It needs to be called whenever the children of the slotted menu items change. To do this, we need to modify the template so that it watches for any added/removed icons that are children of its menu items (viachildren
directive). I've forked the FASTMenu
class (into separate file) and the template to modify them.These modifications are in
menu.foundation.ts
rather thanindex.ts
because this is the kind of bug fix that we would have upstreamed to FAST.π§ͺ Testing
Added unit tests and forked FAST
Menu
tests.β Checklist