Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to table page objects #2308

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Updates to table page objects #2308

merged 12 commits into from
Jul 31, 2024

Conversation

mollykreis
Copy link
Contributor

@mollykreis mollykreis commented Jul 29, 2024

Pull Request

🤨 Rationale

Update the table page object to include functionality needed by some clients. Specifically,

  • Add getHeaderTextContent to the page object so that clients don't have to access the header element to get the text content themselves
  • Export TableColumnMappingPageObject from Angular
  • Extends TablePageObject that's exported from Angular to include a new waitForDataUpdatesToRender to help clients wait for data to be rendered in the table when they are using the data$ property on the Angular table directive, which makes the timing of setData() outside of the client's control

👩‍💻 Implementation

Both the implementation of getHeaderTextContent and waitForDataUpdatesToRender were copied from the sl-table page object in SystemLinkShared.

🧪 Testing

  • Updated a test in nimble-components to use the new nimble-components page object test
  • Wrote new Angular tests to test the Angular page object

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@m-akinc, can you review buddy this PR for me?

@mollykreis mollykreis requested a review from m-akinc July 30, 2024 15:58
@m-akinc m-akinc marked this pull request as ready for review July 30, 2024 16:22
@rajsite rajsite enabled auto-merge (squash) July 31, 2024 20:04
@rajsite rajsite merged commit 50e5761 into main Jul 31, 2024
11 checks passed
@rajsite rajsite deleted the table-page-object branch July 31, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants