-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to table page objects #2308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
commented
Jul 30, 2024
packages/angular-workspace/nimble-angular/table/testing/table.pageobject.ts
Show resolved
Hide resolved
@m-akinc, can you review buddy this PR for me? |
m-akinc
approved these changes
Jul 30, 2024
jattasNI
reviewed
Jul 30, 2024
packages/angular-workspace/nimble-angular/table/testing/table.pageobject.ts
Show resolved
Hide resolved
rajsite
approved these changes
Jul 30, 2024
atmgrifter00
approved these changes
Jul 30, 2024
rajsite
reviewed
Jul 31, 2024
packages/angular-workspace/nimble-angular/table/testing/tests/table-pageobject.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Jul 31, 2024
jattasNI
approved these changes
Jul 31, 2024
packages/angular-workspace/nimble-angular/table/testing/table.pageobject.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Update the table page object to include functionality needed by some clients. Specifically,
getHeaderTextContent
to the page object so that clients don't have to access the header element to get the text content themselvesTableColumnMappingPageObject
from AngularTablePageObject
that's exported from Angular to include a newwaitForDataUpdatesToRender
to help clients wait for data to be rendered in the table when they are using thedata$
property on the Angular table directive, which makes the timing ofsetData()
outside of the client's control👩💻 Implementation
Both the implementation of
getHeaderTextContent
andwaitForDataUpdatesToRender
were copied from thesl-table
page object in SystemLinkShared.🧪 Testing
✅ Checklist