Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook to 8.4 #2470

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Upgrade Storybook to 8.4 #2470

merged 8 commits into from
Nov 14, 2024

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented Nov 13, 2024

Pull Request

🤨 Rationale

I saw that Storybook released a new minor version which is supposed to have a bunch of improvements. An exciting sounding one: "We cut bundle size in half" though the package-lock has about as many additions as subtractions

👩‍💻 Implementation

Followed their docs which basically involved:

  1. Run npx storybook@latest upgrade
  2. Agree to the prompts to auto-update stuff
  3. The tool also suggested we might be able to remove our React dependency but I didn't try this because I know we create some custom React components so it seems correct for us to depend on it

🧪 Testing

  1. Manually inspected our stories including the ones that use custom React components
  2. verified Chromatic did a full rebuild, no turbosnaps, and there are no diffs

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI marked this pull request as ready for review November 13, 2024 20:44
packages/storybook/.storybook/main.js Outdated Show resolved Hide resolved
packages/storybook/package.json Outdated Show resolved Hide resolved
packages/storybook/package.json Outdated Show resolved Hide resolved
@rajsite rajsite merged commit 9ba4f9d into main Nov 14, 2024
14 checks passed
@rajsite rajsite deleted the storybook-8.4 branch November 14, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants