Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaferDie interface/type update #968

Merged
merged 9 commits into from
Jan 20, 2023
Merged

WaferDie interface/type update #968

merged 9 commits into from
Jan 20, 2023

Conversation

DStavilaNI
Copy link
Contributor

Pull Request

🤨 Rationale

This PR provides an update for the WaferMapDie interface by adding a tooltip:string field. This is required for future WaferMap related functionality.

👩‍💻 Implementation

  • Even though the current functionality and visuals stay the same, all of the code modules/files that are using the WaferMapDie type had to be updated, including tests.
  • Renamed a couple of WaferMap tests to make the naming more consistent.

🧪 Testing

  • The WaferMap functionality has been tested manually
  • All of the automated tests have been run locally
  • Chromatic tests are not affected

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@nate-ni nate-ni mentioned this pull request Jan 17, 2023
Open
@DStavilaNI DStavilaNI enabled auto-merge (squash) January 19, 2023 11:37
@DStavilaNI DStavilaNI merged commit 8fba3fd into main Jan 20, 2023
@DStavilaNI DStavilaNI deleted the users/dstavila/wafer-map-tooltip branch January 20, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jattasNI jattasNI jattasNI approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DStavilaNI @rajsite @jattasNI