Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NI-Digital 21.0 API updates #1647

Merged
merged 3 commits into from
Aug 19, 2021
Merged

NI-Digital 21.0 API updates #1647

merged 3 commits into from
Aug 19, 2021

Conversation

sbethur
Copy link
Contributor

@sbethur sbethur commented Aug 17, 2021 •
edited
Loading

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

API parity with NI-Digital Pattern Driver 21.0.0.

  • Properties added:
    • digital_edge_rio_trigger_edge
    • digital_edge_rio_trigger_source
    • exported_rio_event_output_terminal
    • rio_event_terminal_name
    • rio_trigger_terminal_name
    • rio_trigger_type
  • Repeated Capabilities added:
    • rio_events
    • rio_triggers

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

  • Manual review of API metadata
  • Added new system tests for the new rep caps
  • Execution of unit and system tests.

@sbethur sbethur requested a review from marcoskirsch as a code owner August 17, 2021 16:32
@marcoskirsch
Copy link
Member

marcoskirsch commented Aug 18, 2021 •
edited
Loading

It might be a good idea to touch each of the new rep caps in a test, no?

@sbethur
Copy link
Contributor Author

sbethur commented Aug 18, 2021 •
edited
Loading

It might be a good idea to touch each of the new rep caps in a test, no?

Yeah, good point. Other than human review, there is no other validation for them. I'll add some tests. I added new tests.

marcoskirsch
marcoskirsch previously requested changes Aug 18, 2021
View reviewed changes
src/nidigital/system_tests/test_system_nidigital.py Outdated Show resolved Hide resolved
@sbethur sbethur requested a review from marcoskirsch August 18, 2021 23:18
@sbethur sbethur dismissed marcoskirsch’s stale review August 18, 2021 23:19

Addressed the feedback

@marcoskirsch marcoskirsch merged commit 45ee975 into master Aug 19, 2021
@marcoskirsch marcoskirsch deleted the nidigital_21_0_api branch August 19, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoskirsch marcoskirsch marcoskirsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbethur @marcoskirsch