Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_lcr_custom_cable_compensation_data #1911

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

TL;DR: This disables a test as a pre-requisite for updating nimibot driver runtimes.


The nidcpower system test test_lcr_custom_cable_compensation_data fails with the latest driver runtime as documented in #1908.

@marcoskirch and I discussed this offline and agreed to disable the test for now.

As part of the process for updating driver runtimes, we clone the nimi-python repo and run the system tests with the updated driver runtimes. If this fails, it will prevent us from deploying the driver runtime changes.

Therefore we must disable this test before we update our driver runtimes.

List issues fixed by this Pull Request below, if any.

What testing has been done?

None

@marcoskirsch marcoskirsch merged commit 8464d74 into ni:master Apr 7, 2023
@ni-jfitzger ni-jfitzger deleted the disable_failing_nidcpower_test branch April 7, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants