Test niscope fetching more thoroughly and consistently, parameterize channels tested #1956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
Our niscope fetch tests are inconsistent in what they test. Some, like test_read(), check very little, while others are more through. Most of them either perform the same checks or should be performing the same checks.
Additionally, we only test fetching with a single channel list.
In order to test for #1770, both issues are being addressed.
Changes:
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
Ran the tests locally (with the original test_channels_2, test_channels_2_expanded values) with NI-SCOPE 23.1 driver runtime.
I confirmed that test_channels_2 causes the fetch tests to fail, catching the bug.