Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NI-FGEN] Add back pulse width properties #2051

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Conversation

ni-juoca
Copy link
Contributor

@ni-juoca ni-juoca commented Apr 23, 2024

  • This contribution adheres to CONTRIBUTING.md.

  • I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

This change adds back the pulse width properties that were requested by the customer in #1873. Specifically, these properties were added:

* `started_event_pulse_width`
* `done_event_pulse_width` 
* `marker_event_pulse_width`
* `started_event_pulse_width_units`
* `done_event_pulse_width_units` 
* `marker_event_pulse_width_units`

Additionally, a shared EventPulseWidthUnits enum was added for setting the _event_pulse_width_units properties.

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • Ran tox after updating the nifgen metadata.

@ni-jfitzger
Copy link
Collaborator

ni-jfitzger commented Apr 23, 2024

Looks like you have conflicts.
Try pulling down the latest changes, accepting the upstream version and running

tox -e clean
tox -e codegen

@ni-jfitzger
Copy link
Collaborator

You should remove TODOs from the description, once you've addressed them.

@ni-jfitzger
Copy link
Collaborator

This looks good, but we want to wait on an official export.

@ni-jfitzger
Copy link
Collaborator

All tests passed on the previous change.
No need to run them again for a changelog update.

@ni-jfitzger ni-jfitzger merged commit 5206de5 into ni:master Apr 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

marker, or start pulse width
2 participants