[NI-DCPower] Address timeout issues with nidcpower_advanced_sequence.py #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoskirsch
approved these changes
Apr 24, 2024
|
You've got flake8 failures in travis-ci in the example. Run |
ni-jfitzger
approved these changes
Apr 24, 2024
|
FYI @ni-juoca for the PR checkboxes, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This change addresses the timeout issues that prevent
nidcpower_advanced_sequence.pyfrom running out of the box. The fix for this was initially detailed in #1664.More specifically, the timeout is calculated using the source delay, aperture time, and total number of points.
List issues fixed by this Pull Request below, if any.
What testing has been done?
I verified that the test is working with real hardware.