-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post-release validation workflow #2058
Merged
ni-jfitzger
merged 12 commits into
ni:master
from
ni-jfitzger:add-post-release-check-workflow
May 8, 2024
Merged
Add post-release validation workflow #2058
ni-jfitzger
merged 12 commits into
ni:master
from
ni-jfitzger:add-post-release-check-workflow
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't ready for merge yet, because our post-release change needs to go in first. |
ni-jfitzger
changed the title
[DO NOT MERGE] Add post-release validation workflow
Add post-release validation workflow
May 1, 2024
marcoskirsch
requested changes
May 8, 2024
Capitalize PyPI Co-authored-by: Marcos <marcoskirsch@users.noreply.github.com>
Give examples of action parameter values Co-authored-by: Marcos <marcoskirsch@users.noreply.github.com>
ni-jfitzger
commented
May 8, 2024
Capitalize PyPI
marcoskirsch
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Add a workflow to test installing the latest released nimi-python modules from PyPI and running examples.
It will trigger when a release is published on the repo.
Notes:
Why?
Our internal release template mentions installing modules from PyPI and running examples after publishing a release, to validate it. This also requires installing every driver. The whole thing is tedious; we should just have a workflow.
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
Implemented a temporary tweak to trigger the workflow from this PR for the 1.4.8 release.
All tests passed.
Running off a manual trigger or release event remains untested.