Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-release validation workflow #2058

Merged
merged 12 commits into from
May 8, 2024

Conversation

ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Apr 27, 2024

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Add a workflow to test installing the latest released nimi-python modules from PyPI and running examples.
It will trigger when a release is published on the repo.

Notes:


Why?

Our internal release template mentions installing modules from PyPI and running examples after publishing a release, to validate it. This also requires installing every driver. The whole thing is tedious; we should just have a workflow.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

Implemented a temporary tweak to trigger the workflow from this PR for the 1.4.8 release.
All tests passed.

Running off a manual trigger or release event remains untested.

@ni-jfitzger
Copy link
Collaborator Author

This isn't ready for merge yet, because our post-release change needs to go in first.

@ni-jfitzger ni-jfitzger changed the title [DO NOT MERGE] Add post-release validation workflow Add post-release validation workflow May 1, 2024
@ni-jfitzger ni-jfitzger marked this pull request as ready for review May 1, 2024 15:41
@ni-jfitzger ni-jfitzger requested a review from marcoskirsch as a code owner May 1, 2024 15:41
ni-jfitzger and others added 2 commits May 8, 2024 14:01
Capitalize PyPI

Co-authored-by: Marcos <marcoskirsch@users.noreply.github.com>
Give examples of action parameter values

Co-authored-by: Marcos <marcoskirsch@users.noreply.github.com>
@ni-jfitzger ni-jfitzger merged commit 1f93c35 into ni:master May 8, 2024
34 of 35 checks passed
@ni-jfitzger ni-jfitzger deleted the add-post-release-check-workflow branch May 8, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants