Eliminate use of dead and deprecated imports and options in setup.py #2070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Delete deprecated / unsupported imports and distribution options from setup.py. By doing this proactively, we can avoid being broken in the future.
According to GitHub Copilot,
setuptools.command.test
provides a way to setup for and run tests. It would happen in this case when users runpython setup.py test
.The problems with that are:
tests_require
andtest_suite
) are no longer recognized.For these reasons, it makes sense to just remove the import and everything related to it.
I also eliminated the setup_requires because it's considered deprecated and we won't be needing pytest-runner.
List issues fixed by this Pull Request below, if any.
What testing has been done?
PR Checks