Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ISSUE TEMPLATE functionality #2071

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Jan 26, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • [] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR replaces our old issues template with a new one.


Currently, when I create a new issue for the repo, it's blank, despite our ISSUE_TEMPLATE.md. This seems to be because we've been using a legacy issue template feature and GitHub probably turned it off (although the newer feature is supposedly in beta).

Following the instructions here I went through the steps to setup a bug report template (and copied our ISSUE_TEMPLATE.md for the content.

I also configured it to auto-assign the 'bug' label.

This PR will commit the new issue template and delete the old one.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

Delete original issue template. Content was moved to the new template
@ni-jfitzger ni-jfitzger changed the title Update issue templates Restore ISSUE TEMPLATE functionality Jan 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (afd791e) to head (ae807bd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2071   +/-   ##
=======================================
  Coverage   91.33%   91.34%           
=======================================
  Files          66       66           
  Lines       16274    16274           
=======================================
+ Hits        14864    14865    +1     
+ Misses       1410     1409    -1     
Flag Coverage Δ
codegenunittests 84.95% <ø> (ø)
nidcpowersystemtests 94.59% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.20% <ø> (ø)
nidigitalunittests 68.45% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 87.24% <ø> (ø)
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd791e...ae807bd. Read the comment docs.

@ni-jfitzger
Copy link
Collaborator Author

I wonder if we should update the template to mention our security policy. A reminder to users before they create a public bug to not report security issues through public bugs.

@ni-jfitzger ni-jfitzger merged commit c403143 into master Jan 26, 2025
36 checks passed
@ni-jfitzger ni-jfitzger deleted the ni-jfitzger-restore-issue-template-functionality branch January 26, 2025 20:47
@ni-jfitzger
Copy link
Collaborator Author

I wonder if we should update the template to mention our security policy. A reminder to users before they create a public bug to not report security issues through public bugs.

Probably not necessary, given what now pops up when you go to create an issue.

image

The option to report a security vulnerability is right there, so that should be a solid enough nudge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants