Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "id to index" bug #109

Merged
merged 10 commits into from
Jun 24, 2018
Merged

Fix "id to index" bug #109

merged 10 commits into from
Jun 24, 2018

Commits on Jun 24, 2018

  1. Fix incorrect description

    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    a1f5153 View commit details
    Browse the repository at this point in the history

  2. Fix wording

    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    9c92ae9 View commit details
    Browse the repository at this point in the history

  3. Assert should come after a check if tokenId is valid 

    Otherwise we can mask the actual error.
    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    264310a View commit details
    Browse the repository at this point in the history

  4. Set idToIndex when token is minted and put to the global array

    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    8af7ad4 View commit details
    Browse the repository at this point in the history

  5. Update unit tests 

    - Don't set up tests to use default values (non-existing mapping value returns default value and can mask a problem)
- Change some arbitrary index values to less conflicting numbers (for clarity).
    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    317c2c0 View commit details
    Browse the repository at this point in the history

  6. Add asserts to for tokens and idToIndex 

    They are dependable data structures and should be always in sync.
    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    26ca313 View commit details
    Browse the repository at this point in the history

  7. Update package-lock.json

    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    e9f11a6 View commit details
    Browse the repository at this point in the history

  8. Remove redundant code 

    We shrink tokens array with tokens.length-- which makes tokens[lastTokenIndex] = 0 redundant.
    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    95c84a4 View commit details
    Browse the repository at this point in the history

  9. Unit test typo fix

    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    b0f3562 View commit details
    Browse the repository at this point in the history

  10. Add assert comments

    @lknix
    lknix committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    9984f29 View commit details
    Browse the repository at this point in the history