Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with schemas that include a period "." #27

Closed
cawise opened this issue Jul 27, 2022 · 7 comments
Closed

Problem with schemas that include a period "." #27

cawise opened this issue Jul 27, 2022 · 7 comments
Labels

Comments

@cawise
Copy link

cawise commented Jul 27, 2022

We are using multi-part schemas ("sub-schemas", if you like) that include a dot to separate the "parent schema" from the "sub-schema" like [Technology.Logging]. In most cases, this extension works as expected. However, when the table name happens to be a prefix/substring of the "sub-schema", it groups weirdly -- as though the table name is removed from the schema name and leaves any remaining letters.

In the image below, you can see a few examples of this.
[Technology.LandingPages].[LandingPage] yields "Technologys"
[Technology.Logging].[Log] yields "Technologyging"

image001

nicholas-ross added a commit that referenced this issue Jul 28, 2022
@scottkuhl
Copy link

Should we expect a release with this fix in soon or are you waiting for more issues / features to add before doing one? Just asking to determine if we should pull the code down and do our own internal release or wait for an official one.

Thanks for the quick fix!

@nicholas-ross
Copy link
Owner

I will be adding Folder Levels for the next release and need to update the localisation of the new features.

Since I'm not sure when it will be complete, I have done a beta release of the current build.

@cawise
Copy link
Author

cawise commented Aug 1, 2022

Beta works great! Thanks for the quick fix!

@cawise
Copy link
Author

cawise commented Aug 3, 2022

Here's a related issue, but I can open as a separate item if you like.

With these "multipart" schema names, when the Object Display Options > Rename Node option is set to True, it only strips off the first part of the schema name.

image

@nicholas-ross
Copy link
Owner

Thank you. I am aware of it.

It was a performance consideration I made at the time. To get the accurate object name a call to GetService for each node is required. I'm already doing this once but the rename was a different method and didn't want to repeat the same call. After merging in my folder level code I have decided it needs to be rewritten to parse all the folder levels and name with one call.

@nicholas-ross
Copy link
Owner

See release v1.4-beta2.

@cawise
Copy link
Author

cawise commented Aug 8, 2022

Once again, works well and thanks for the quick fix!

micjahn pushed a commit to micjahn/SSMS-Schema-Folders that referenced this issue Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants