Skip to content

Commit

Permalink
Revert "ci: check if crate can be packaged"
Browse files Browse the repository at this point in the history
This reverts commit fc5c0a9.

When `cargo package` builds `uefi`, it does so with dependencies from
crates.io. That causes a problem if `uefi` depends on some not-yet-released API
changes in `uefi-raw` or `uefi-macros`. For example, see:
rust-osdev#1383 (comment)

I couldn't find a way to force it to use local deps, so revert the job for now.
  • Loading branch information
nicholasbishop committed Aug 29, 2024
1 parent 41a3cb4 commit 91b245e
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,16 +127,6 @@ jobs:
# library packages. Note that xtask isn't used or built here; since it's
# just a dev tool we don't care about the MSRV for that package.
run: cargo build --target x86_64-unknown-uefi -p uefi-test-runner
# Tests that the published crates keep being package-able (thus, releasable).
package:
name: Package Crates
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
- uses: Swatinem/rust-cache@v2
- name: Build
run: cargo package -p uefi -p uefi-raw -p uefi-macros
# This job requires the nightly channel, but keep it as a separate job from
# `nightly_channel` because it takes a while to run.
build_feature_permutations:
Expand Down

0 comments on commit 91b245e

Please sign in to comment.