Skip to content

Commit

Permalink
fix(button): keep transparent color in dark mode
Browse files Browse the repository at this point in the history
This patch updates the `<Button>` component to keep the same transparent
color when in dark mode that is used in light mode. This variant is only
ever used on top of already colorful content (e.g. images or videos) and
thus switching the background color in dark mode doesn't make sense.
  • Loading branch information
nicholaschiang committed Aug 12, 2023
1 parent 0004aba commit f2b4002
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions app/components/ui/button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ const buttonVariants = cva(
variant: {
default:
'bg-gray-900 text-gray-50 shadow hover:bg-gray-900/90 dark:bg-gray-50 dark:text-gray-900 dark:hover:bg-gray-50/90',
transparent:
'bg-gray-900/40 text-gray-50 hover:bg-gray-900/50 dark:bg-gray-50/40 dark:text-gray-900 dark:hover:bg-gray-50/50',
transparent: 'bg-gray-900/40 text-gray-50 hover:bg-gray-900/50',
destructive:
'bg-red-500 text-gray-50 shadow-sm hover:bg-red-500/90 dark:bg-red-900 dark:text-red-50 dark:hover:bg-red-900/90',
outline:
Expand Down

0 comments on commit f2b4002

Please sign in to comment.