Expose nanobind's stubgen as a py_binary
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `typing_extensions` as a unconditional dependency for the stubgen target. The plan is to wrap the py_binary into a nanobind stubgen rule that lives in the same file as all other rules.
Everything is being forwarded to the py_binary that previously existed in the top-level BUILD file. There are still some difficulties locating the module object, since it exists in multiple places. Maybe it too needs to be sourced from $BINDIR.
Stubgen does not understand file system paths to modules, so we need to make an indirection and convert paths to nanobind extension targets to Pythonic module paths via a Python script.
nicholasjng
force-pushed
the
add-stubgen
branch
3 times, most recently
from
38f445d
to
28df2cc
Compare
Extracts runfiles dir and bindir from the invoker's script path, and proceeds to put the generated stub file directly into the $(BINDIR). What is left outstanding is to support pattern and marker files, but that has lower prio for now.
nicholasjng
force-pushed
the
add-stubgen
branch
8 times, most recently
from
a9e24a7
to
6d5c1bf
Compare
This makes the bindir available from Windows. Also, harden the stub output path generation on Windows in the case that the binary location in runfiles is not a symlink. Also also, add a pattern file to the binary's data deps if provided, ensuring that the file exists in the repo as an addressable target, and is visible to the stubgen wrapper in the runfiles dir.
|
Finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
typing_extensionsas a unconditional dependency for the stubgen target.The plan is to wrap the
py_binaryinto a nanobind stubgen rule that lives in the same file as all other rules.Closes #14.