Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with temp files crashing precompiler #3

Closed
wants to merge 3 commits into from
Closed

Fixed issue with temp files crashing precompiler #3

wants to merge 3 commits into from

Conversation

paton
Copy link
Contributor

@paton paton commented Jan 8, 2013

Added a simple check to block temp files from accidentally being sent into processTemplate(), which crashes the process.

@nicjansma
Copy link
Owner

Hi paton,

I realize this is a year old but I'd be interested in merging it. Is there a reason you removed several console.log()s?

@paton
Copy link
Contributor Author

paton commented Mar 18, 2014

I think it's generally best practice for node modules not to output things to the console.

Console.log()s might be useful for debugging purposes, though. Maybe the 4th argument on watchDir can be debug which, if true, allows the console.logs

exports.watchDir = function(dir, outfile, extensions, debug) {

@nicjansma
Copy link
Owner

I would agree, or at least make the output optional. As you've noted, there's another pull request that is making the console.logs optional which is great.

For the purposes of this PR, would you want to revert the console.log() changes and have it just do the temp file fix?

@nicjansma
Copy link
Owner

Merged your fix into 16a3f4d

@nicjansma nicjansma closed this Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants