Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't wait after timeout nor final attempt failed #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

popcube
Copy link

@popcube popcube commented Mar 8, 2024

Replace the bullet points below with your answers

Description

  • What change is being made and why?

Skip waiting for [retry_wait_seconds] seconds for both timeout and attempt failure conditions when the remaining retry is zero.
It should save some computing resource and wait time.
Fixes #134

Testing

No test was added.

@popcube popcube changed the title fix: don't retry after timeout nor final attempt failed fix: don't wait after timeout nor final attempt failed Mar 9, 2024
@popcube
Copy link
Author

popcube commented Mar 9, 2024

Hello pr name was misleading so I changed to the current one.
Please let me know if anything is needed from me.
Thank you for making this awesome action.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 2.50%. Comparing base (3f75758) to head (3d8798d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #135      +/-   ##
=========================================
- Coverage    2.53%   2.50%   -0.04%     
=========================================
  Files           3       3              
  Lines         158     160       +2     
  Branches       51      55       +4     
=========================================
  Hits            4       4              
  Misses        141     141              
- Partials       13      15       +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip waiting for retry_wait_seconds after final attempt failed
2 participants