-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dummy test app #19
Merged
Merged
Dummy test app #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 7, 2018
pablobm
force-pushed
the
dummy-test-app
branch
from
January 25, 2019 15:34
a570177
to
8d19891
Compare
houndci-bot
reviewed
Jan 25, 2019
houndci-bot
reviewed
Jan 25, 2019
@nickcharlton - I made the last few required changes. I think this is good to go. I have two questions though:
|
I am, you'll be happy to hear, finally merging your work here! I think removing them in fine and if it turns out to not be, is not that significant. We do indeed include the lock files for Appraisals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I merged #18, @nickcharlton threw the question of how we could go about testing that. This PR attempts to provide an answer.
Here I set up an dummy app, same as the ones used for engines, as well as feature specs that run on this dummy app.
There are a bunch of files because setting this up is not trivial. In summary, I added:
spec/dummy
. I copied it from a newly-created engine project and adapted it to work here.has_many
relationship.administrate-field-nested_has_many
.To run the tests:
bundle exec appraisal rake
. Should document this and set it up on CI.To run the dummy app:
rails s
.On an implementation note, there's too much logic in the template at
app/views/fields/nested_has_many/_show.html.erb
. This is because I couldn't get a helper to work.