Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attribute grouping #79

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

trevorrjohn
Copy link
Contributor

In Administrate v0.20.0, support was added for grouping fields but this was not compatible with this field type.

Recreates #66

Fixes #65

In Administrate v0.20.0, support was added for grouping fields but this
was not compatible with this field type.

thoughtbot/administrate#2422

Fixes nickcharlton#65
@trevorrjohn
Copy link
Contributor Author

@nickcharlton sorry, I renamed master to main and it auto closed the PR. I couldn't figure out how to re-open it and change the branch name.

@HuntBurdick
Copy link

I'm using this branch so I can use the latest administrate gem version and everything seems to be working well until I hit a validation error. If I hit the validation error with a new record, any in progress values are persisted and repainted to the form but if there is a validation error on an existing record, all in progress values are lost and not repainted to the form. I have been debugging this all day and I'm at a bit of a loss. This is a big blocker for me and will be debugging until I find a solution. Does this happen for you as well?

@HuntBurdick
Copy link

Ah looks like it's something with my implementation. Did a fresh install and this issue does not exist out of box. I'm suspecting the friendly ID gem I'm using might be interfering. Please disregard, thanks.

@nickcharlton
Copy link
Owner

Thanks for checking back in, @HuntBurdick. If there are specific issues with this gem/Administrate itself, please open a new issue if you come across them!

@nickcharlton nickcharlton merged commit e2ee130 into nickcharlton:main Feb 14, 2024
1 check passed
@gustavosobral
Copy link

@nickcharlton are you planning to make a new release that cover this change soon? Just this bug is blocking our update to the latest administrate

@nickcharlton
Copy link
Owner

Oh! …yes, I should. I'll do that as soon as I can, I'm not aware of anything which should hold us back.

@nickcharlton
Copy link
Owner

I've just released v2.1.0 which means this is now released. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with attribute grouping (Administrate 0.20.0)
4 participants