add ability to parse cobertura files #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ly-cultureiq! |
|
I'm not sure this should have been merged @nickmerwin ... cobertura-parse is archived and is also quite big. I mean for Christ's sake, they have mocha in dependencies... IMO we should revert this and if you really want this to be added, we should fork the repo, bring it to a good shape and publish it on npm. |
XhmikosR
reviewed
Nov 21, 2019
| @@ -5,7 +5,7 @@ | |||
| "coverage", | |||
| "coveralls" | |||
| ], | |||
| "version": "3.0.7", | |||
| "version": "3.0.8", | |||
There was a problem hiding this comment.
Also please never do this @ly-cultureiq. This is for the maintainers to decide
There was a problem hiding this comment.
point taken - my apologies
nickmerwin
pushed a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for files that can be produced by pytest and coverage.py and many other job runners.
if this gets merged ill have a small PR for the github action to use this new setting